Haven't made them for years, think I got into the "they are cheap and plentiful in the supermarkets" mentality. Mind you they don't taste as good as home made ones. So I have brushed that thought out of my mind and had a go at making some of my own. Fresh pickling onions are in season now and were readily available loose in my local supermarket too.
If you do decide to make your own don't be led down a path of buying the vinegar ready spiced from a shop or supermarket. The joy comes from making your own spiced vinegar and you can buy the spices (dried chilis, mace, peppercorns, coriander seeds, mustard seeds, and bay leaves) ready mixed as 'pickling spice' and packed in sachets or packets ready to go, you don't have to go to the trouble of buying all the individual spices and blending them. Its far cheaper this way too.
Can't you just imagine opening a jar of these tangy, sweet, spicy, crunchy beauties over Christmas, with cold meats, cheeses and the like and eating the whole jar? I think they look amazing, even if I say so myself!